Hi, Prasanta.
On 27.08.2020 02:59, Prasanta Sadhukhan wrote:
I have added the evaluation to JBS and I can see the issue even in 6u211, 7u281
too in my windows10.
- I checked behavior of the test on macOS and it looks like the JFileChooser has only 3 columns:
"name", "Size", "date".
How it is intended to work after your fix? I guess you need to change the
Win32ShellFolder2 not the ShellFolder.
- You do not need to print stack trace here, just exit the test:
try {
UIManager.setLookAndFeel("javax.swing.plaf.metal.MetalLookAndFeel");
} catch (ClassNotFoundException | InstantiationException |
IllegalAccessException
| UnsupportedLookAndFeelException e) {
e.printStackTrace();
}
Regards
Prasanta
-phil.
On 8/24/20, 7:27 AM, Prasanta Sadhukhan wrote:
Hi All,
Please review a fix for a JFileChooser issue where it is seen that if we open the dialog and click
on "Details" view and then click on "Home" button,
the "Modified" time is shown in "Type" field. This issue is present from at
least jdk8 onwards.
Issue is because for ShellFolder#getFolderColumnValue handles "name", "Size", "date"
cases ignoring "Type" case so date value is shown in Type field.
Proposed fix is to handle folder "Type" case too and also "Date" value is
formatted correctly
to show in same format as other non-shellfolder options and
also to be same as "native" time format for same folder.
Bug: https://bugs.openjdk.java.net/browse/JDK-8250935
webrev: http://cr.openjdk.java.net/~psadhukhan/8250935/webrev.00
Regards
Prasanta
P.S: There is still some issue regarding the header values recursively inside
Shellfolders which will handled subsequently in separate issue
--
Best regards, Sergey.
