On Fri, 2 Oct 2020 22:15:23 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
>> Please review a fix for an issue where minimumLayoutSize and >> preferredlayoutSize of MetalRootLayout class wrongly uses >> the width of the title pane in the height calculation: Proposed fix is to >> rectify the anomaly and use tpHeight for >> height calculation. >> All closed, open jtreg and JCK tests and SwingSet2 Metal L&F are unaffected >> by this change. > > src/java.desktop/share/classes/javax/swing/plaf/metal/MetalRootPaneUI.java > line 539: > >> 537: >> 538: return new Dimension(Math.max(Math.max(cpWidth, mbWidth), >> tpWidth) + i.left + i.right, >> 539: cpHeight + mbHeight + tpHeight + i.top >> + i.bottom); > > Is it possible to check this change by some testcase? I tried at the time of PR but unable to check as MetalRootLayout is private so not able to access its methods. That is why I ran all client-tier3 jtreg and jck tests, and mach5 job link is posted in JBS. ------------- PR: https://git.openjdk.java.net/jdk/pull/433
