On Sat, 12 Dec 2020 23:32:59 GMT, Phil Race <p...@openjdk.org> wrote:
>>> Since the apple forum post is still unanswered and if we want it to be >>> fixed for JDK16, I dont see any other alternative than to fix by what I did >>> in the 1st iteration of this by hardcoding. I dont think we are going to >>> enable dark mode in JDk16 so we will have time to think on that when we >>> enable that and hopefully Apple will come back by that time and we can >>> revisit this. >> >> Can you try some small sample code and create the tabpane using Cocoa then >> set some state to the pane(like selected) and request its font? > > Where exactly is this forum post ? > The current version of the fix isn't obviously hard-coding it. The source > looks to be > NSColor selectedControlColor > > how is that hard-coded ? > > Why isn't that sensitive to dark vs light theme ? The forumpost is here https://discussions.apple.com/thread/252067605 The hardcoded being referred was in this 1st iteration of the fix https://openjdk.github.io/cr/?repo=jdk&pr=1182&range=00 ------------- PR: https://git.openjdk.java.net/jdk/pull/1182
