On Wed, 16 Dec 2020 19:46:57 GMT, Phil Race <p...@openjdk.org> wrote:
>> Hello, >> >> This is a review request for straight back port of the fix for the bug >> JDK-8255880 from JDK 17 to JDK 16, which is currently in RDP 1 phase. The >> fix was tested and the regression test was executed on MS Windows OS, Linux >> OS, macOS. >> >> Thank you, >> Anton > > Fine but in that casw why didn't you withdraw the 17 PR and just push to 16 > which will get forward synced ? Hello Phil. For me the main goal was to fix this bug in the latest JDK feature release, that is why I initiated integration to "openjdk/jdk" as soon as the fix was approved there. Integration of this fix to "openjdk/jdk" repository was my first integration to OpenJDK project in Git, at that moment I did not anticipate that obligatory synchronization from "openjdk/jdk16" to "openjdk/jdk" yet. Today based on the fact that this bug is P3 and not an enhancement and that following "fix-request" process in JBS is not prescribed for this type of bug in RDP 1 phase, and that this bug on Monday still was targeted to JDK 16, I came to a conclusion that there is legal right to go through this back port procedure to try to deliver the fix to JDK 16. I thought that there would not be a trouble during this synchronization, because in Mercurial such cases during merge were handled automatically silently. Hopefully Git will manage to handle it automatically. I guarantee that this is the first and last time from my side, next times, if there are, I will not be initiating back ports to stabilization repositories in pre-RDP 2 phases, if the fix is integrated to always open repository. On 16/12/2020 19:47, prrace wrote: > > *@prrace* approved this pull request. > > Fine but in that casw why didn't you withdraw the 17 PR and just push > to 16 which will get forward synced ? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://urldefense.com/v3/__https://github.com/openjdk/jdk16/pull/38*pullrequestreview-554028620__;Iw!!GqivPVa7Brio!Klj4EK4RrD6Ivj-inV3MaaZOe1byFdk_Gc3CiAQr3B7qKv70SsuZx4n6HCvGZl9q6Xg$>, > > or unsubscribe > <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AQY7S7HOZTSK3ZGZNM3A5R3SVEFEBANCNFSM4U6PRW5Q__;!!GqivPVa7Brio!Klj4EK4RrD6Ivj-inV3MaaZOe1byFdk_Gc3CiAQr3B7qKv70SsuZx4n6HCvGh1BcT_U$>. > ------------- PR: https://git.openjdk.java.net/jdk16/pull/38