On Wed, 6 Jan 2021 14:28:29 GMT, K Suman Rajkumaar <github.com+70650887+skoda...@openjdk.org> wrote:
>> Hi All, Could you please review this fix for JDK16? >> >> Problem Description: The test >> open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java is applet based. >> >> Fix: Rewritten the above applet based test to a regular java test. >> >> Best Regards, >> K Suman Rajkumaar > > K Suman Rajkumaar has updated the pull request incrementally with one > additional commit since the last revision: > > Updated with another set of review comments from Alexey > > Updated with another set of review comments from Alexey. Changes requested by aivanov (Reviewer). test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java line 125: > 123: }); > 124: frame.setSize(760, 250); > 125: frame.pack(); `setSize` is redundant when you call `pack`. The latter will also set size of the frame based on the preferred size determined by the layout manager. ------------- PR: https://git.openjdk.java.net/jdk/pull/1878
