On Tue, 12 Jan 2021 04:26:19 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:

> The spec of the update method seems outdated:
> * Find the new toggle button that focus needs to be
> * moved to in the group, select the button
> 
> BTW I am not sure why the Aqua is so specific and requires an additional 
> press while the same radio buttons do not require that. Is it possible that 
> some fix was implemented in the shared code so now all L&F skip the "space"?

The AquaL&F also does not need the additional "space" press for JRadioButton. 
During the fix of JDK-8226892, code was added for other L&F, so that the 
additional "space" press is not needed. But same code was not added for 
AquaL&F. So, the additional key press was needed. Now, the additional press 
should not be needed for AquaL&F also for JRadioButton. So now, for all L&Fs, 
the additional key press is needed for JToggleButton and is not needed for 
JRadioButton.

I did not add radio button to spec as RadioButton are also ToggleButton only. 
But yes, I will highlight that. So I will update the spec as below. Hope that 
is ok.
         * Find the new toggle/radio button that focus needs to be
         * moved to in the group, select the button

-------------

PR: https://git.openjdk.java.net/jdk16/pull/99

Reply via email to