On Fri, 15 Jan 2021 06:33:19 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org>
wrote:
>> This test was unstable in linux in nightly testing. Modified to move the
>> frame to center of screen so that the left-taskbar of linux doesn't
>> interfere with the mouse movement along with delay after frame is visible to
>> make it more stable.
>> Mach5 job running for several iterations on all platforms is ok. Link in JBS.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Address review comments
Changes requested by aivanov (Reviewer).
test/jdk/javax/swing/JPopupMenu/8075063/ContextMenuScrollTest.java line 93:
> 91: JMenuItem delete;
> 92: JMenuItem selectAll;
> 93: JMenuBar menuBar;
Why at the top of the method instead of the first usage?
What about `undo`, `redo`, `cut`, `copy`? I cannot see they're used anywhere
else but this method too.
test/jdk/javax/swing/JPopupMenu/8075063/ContextMenuScrollTest.java line 80:
> 78: robot.mouseWheel(1);
> 79: robot.waitForIdle();
> 80: if (!menu.isPopupMenuVisible()) {
This still calls `menu.isPopupMenuVisible()` on main thread, doesn't it?
-------------
PR: https://git.openjdk.java.net/jdk/pull/2061
