On Fri, 15 Jan 2021 18:07:25 GMT, Stanimir Stamenkov <github.com+1247730+sta...@openjdk.org> wrote:
>> Fix for [JDK-8257664][] – HTMLEditorKit: Wrong CSS relative font sizes. >> >> _Disclaimer:_ I'm the reporter of the issue and I've been advised the best >> chance to get it addressed is to submit a pull request against this >> repository. I haven't built the JDK myself, I'll need guidance if required. >> I have a proof-of-concept example – demonstrating the bug and a workaround >> available as a [public >> gist](https://gist.github.com/stanio/b79ce9348946aa6b3395328ec4c59d14). I >> have included a sample test though I don't know if it is annotated properly. >> >> **Current behavior** >> >> <style> >> h2, .h2 { font-size: 150% } >> </style> >> >> <body> >> >> <h2>Foo</h2> >> >> <div class=h2>Bar</div> >> >> <ol class=h2> >> <li>Baz</li> >> </ol> >> >> <table class=h2> >> <tr> >> <td>Qux</td> >> </tr> >> </table> >> >> </body> >> >> **Expected behavior** >> >> All text should be displayed with a font size of the computed `<body>` >> font-size × 1.5. >> >> [JDK-8257664]: https://bugs.openjdk.java.net/browse/JDK-8257664 > > Stanimir Stamenkov has updated the pull request incrementally with one > additional commit since the last revision: > > fixup! 8257664: Fix font-size inheritance with percentage values > > Init the "fontSizeInherit" value using the instance "StyleSheet.css". Looks good to me. The test runs successfully on headless hosts in mach5. As for the visual inspection, I thought about creating a frame with JEditorPane but saving an image is will also work on headless systems. That is to say, saving the image is even better. src/java.desktop/share/classes/javax/swing/text/html/StyleSheet.java line 1737: > 1735: * property values, Cascading, and Inheritance</a> > 1736: */ > 1737: Object fontSizeInherit() { The method can be private, right? ------------- PR: https://git.openjdk.java.net/jdk/pull/1759
