On Tue, 26 Jan 2021 17:34:04 GMT, Matthias Perktold <github.com+7334069+mperkt...@openjdk.org> wrote:
> > You can create the new PR with comments addressed and link to the old PR in > > the description. > > Is there anything special I need to do to have "comments addressed"? Should I > first apply your patches, and then proceed with the new fork afterwards? Whatever you like. You can incorporate the fixes to comments in your initial commit to the new branch, or you can fix them after you create the new branch with your exiting changeset. > > Can you edit the subject of the JBS issue to amend the constant > > W3C_LENGTH_UNITS? > > I don't think I have the rights to do this. I don't even have an JBS account, > I submitted the bug through the https://bugs.java.com/bugdatabase/. I just > recently signed the OCA, is that sufficient to create a JBS account? No, it is not sufficient. I have amended the subject of the bug. I wondered why I didn't see OCA request in the PR. You had gotten it before you created your first PR. ------------- PR: https://git.openjdk.java.net/jdk/pull/2223
