On Tue, 9 Feb 2021 07:27:00 GMT, Tejpal Rebari <treb...@openjdk.org> wrote:
>> Please review the following fix for jdk17. >> In this fix i have deprecated and marked for removal following classes and >> methods >> public void intervalAdded(ListDataEvent e) >> public void intervalRemoved(ListDataEvent e) >> protected boolean lt(File a, File b) in BasicDirectoryModel.java >> >> inner class PropertyChangeHandler, VSBChangeListener, HSBChangeListener, >> ViewportChangeHandler in BasicScrollPaneUI.java >> inner class MouseInputHandler in BasicMenuItemUI.java >> method BasicToolBarUI.java#createFloatingFrame >> >> From 8049700 not deprecated the paintText(Graphics g, JComponent c, >> Rectangle textRect, String text) method in BasicButtonUI as AquaButtonUI, >> MetalButtonUI and MetalToggleButtonUI overrides it. >> Similarly not deprecated ChangeHandler of BasicMenuUI as AquaMenuUI and >> MotifMenuUI uses this class. > > Tejpal Rebari has updated the pull request incrementally with one additional > commit since the last revision: > > removed deprecation from methods of class which is also getting deprecated Are these methods all expected to be used only by a L&F rather than an application ? If by an application, then forRemoval seems too strong to me. If by a L&F then I think you need to go research what open source L&Fs there are out there and see how many of them are affected. Then we can decide about forRemoval. ------------- Changes requested by prr (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/1958
