On Mon, 8 Mar 2021 06:37:07 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refactoring > > src/jdk.accessibility/windows/native/common/AccessBridgeDebug.cpp line 35: > >> 33: #include <windows.h> >> 34: #include <cstdlib> >> 35: #include <cstring> > > Matter of taste, but I would prefer stdlib.h and string.h instead of cxxx. > Just to keep in line with the rest of the coding. Weird mix of styles > otherwise (I mean this code still uses 16bit era Windows APIs). AccessBridgeDebug has `.cpp` in its extension, so the compiler can handle it as C++ code, and also "cstring" seems to be prefer to "string.h" in @mrserb 's comment. It's nature to use "cstring" in C++ source code IMHO. Let's see comments from the others. ------------- PR: https://git.openjdk.java.net/jdk/pull/2859
