On Wed, 10 Mar 2021 00:55:00 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
>> Continuation of review at https://github.com/openjdk/jdk/pull/380 > > Just to continue the thread from the old review, did you have a chance to > look at the possibility of loading all existed icons embedded in the file? It > was discussed here: > https://github.com/openjdk/jdk/pull/380#issuecomment-702999573 > Just to continue the thread from the old review, did you have a chance to > look at the possibility of loading all existed icons embedded in the file? It > was discussed here: > [#380 > (comment)](https://github.com/openjdk/jdk/pull/380#issuecomment-702999573) Yes, i did. There were 3 shortcomings: 1. It works in about 10% of the cases in all other cases it reports only one icon available (32x32) even if there are other resolution icons. 2. It is quite slow, especially on network drives. 3. Does not work at all in files that are within AppData\Roaming folder - returning list is just empty. ------------- PR: https://git.openjdk.java.net/jdk/pull/2875
