On Thu, 1 Apr 2021 15:48:53 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org>
wrote:
>> A public overriding method
>> JMenu.setComponentOrientation(java.awt.ComponentOrientation)
>> has no spec.
>> Added spec for the method.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> javadoc change
src/java.desktop/share/classes/javax/swing/JMenu.java line 1259:
> 1257:
> 1258: /**
> 1259: * Sets the orientation for this menu and the associated popup
> component
Suggestion:
* Sets the orientation for this menu and the associated popup menu
I think *popup component* isn't specific enough.
Maybe “and *its* associated…” is even better?
src/java.desktop/share/classes/javax/swing/JMenu.java line 1260:
> 1258: /**
> 1259: * Sets the orientation for this menu and the associated popup
> component
> 1260: * determined by the <code>ComponentOrientation</code> argument.
Suggestion:
* determined by the {@code ComponentOrientation} argument.
The new code should use javadoc syntax.
src/java.desktop/share/classes/javax/swing/JMenu.java line 1265:
> 1263: * the popup menu component contained within it.
> 1264: */
> 1265: public void setComponentOrientation(ComponentOrientation o) {
For consistency, I suggest using the same wording here as in the introduction
sentence.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3213
