On Thu, 8 Apr 2021 04:58:14 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

>> The current spec for 
>> javax/swing/plaf/BorderUIResource.BevelBorderUIResource.html(int,java.awt.Color,java.awt.Color)
>>  does not clearly specify the usage of color for hightlight and shadow as 
>> there are outer/inner hightlight and outer/inner shadow.
>> Updated spec to clarify the same.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   javadoc change in BevelBorder constructor

src/java.desktop/share/classes/javax/swing/border/BevelBorder.java line 89:

> 87:      * Creates a bevel border with the specified type, highlight and
> 88:      * shadow colors.
> 89:      * highlightOuterColor and highlightInnerColor will be derived from

I think we should use just a brief text for "highlightOuterColor"/etc like in 
the other parts of class "the outer shadow"/"the inner shadow"/"the inner 
highlight" etc.  Since in this particular case the highlightOuterColor is not a 
parameter nor a field.
And please update the copyright dates.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3305

Reply via email to