On Thu, 15 Jul 2021 07:55:11 GMT, Jayathirth D V <j...@openjdk.org> wrote:
>> Do not test situation where UIResource icon is returned >> Added a whole bunch of debug information to see what file test is filed >> upon. > > test/jdk/javax/swing/JFileChooser/FileSystemView/SystemIconTest.java line 85: > >> 83: // Default UI resource icon returned - it is not covered >> 84: // by new implementation so we can not test it >> 85: continue; > > I see that we are hitting this condition for all sizes on my 10.15.7 mac. > Basically making testSystemIcon() to not run in my Mac. Do we have any other > use case where we dont hit this condition in Mac or non-Windows platform? I tested on Ubuntu - it does not hit that condition. In future, when similar functionality with multiresolution icons might be implemented on Mac we might pass the test on Mac in similar way but right now it is implemented using the UIResourceIcon and that is - while being within spec - makes test to fail. ------------- PR: https://git.openjdk.java.net/jdk/pull/4776
