On Wed, 11 Aug 2021 09:03:57 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
> The test fails in CI testing citing expected "rededited" but found > "redEDITED", which seems to point to fact that either there is a CAPS_LOCK > key switched on or some other test did not use SHIFT key corectly ie, > pressed but not released. > > Considering many more tests would have failed if CAPS_LOCK is turned on, I > tried to find if some tests uses SHIFT key mistakenly and it seems > JRadioButton test has press/release order wrong and it uses SHIFT. Rectified > that. > > In addition, corrected some known CI issues ie waiting after frame is made > visible, made frame to centre. Along with that, also modified testcase to > check lowercase string. Since the original JDK-4275046 issue is about newly > entered text is made part of cell or not, it does not matter if it's in > lowercase/uppercase and if such CAPS_LOCK or Shift key problem happens again, > this test will not be affected. > > CI run for several iterations running these 2 tests one after another in all > platforms is green. Marked as reviewed by serb (Reviewer). Yes this cleanup looks fine, I just would like to highlight that the actual root cause of this issue is one of: - Someone presses the buttons while the test is executed - A few tests are executed in parallel(bug in jtreg or mach5?) - Bug in KVM which generates this button press. All of them are more important than the current cleanup, and I suggest investigating those possibilities on the lab_support+client_team chats ------------- PR: https://git.openjdk.java.net/jdk/pull/5079
