On Mon, 16 Aug 2021 04:36:03 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
> > We should either prevent null being set or catch all those nulls. > > I did that in 1st iteration of this > PR..https://github.com/openjdk/jdk/pull/4989/files/2a2ab50ded3305f3a9e0f01e90417b484a0b2db4 > > @prrace Should I bring that fix back? > You are reading my "there are two options text" and the code you propose to bring back is NOT the option I recommended. > > Just add advisory doc on the protected field too. > > > ok, this is part of what this change do, probably the text should be > > rephrased there? > > What should be the advisory phrase? Will the text I have added in the > > protected field doc not suffice? Something like "subclassers must ensure this is set to a non-null value during construction and not set this to null" ------------- PR: https://git.openjdk.java.net/jdk/pull/4989
