On Wed, 11 Aug 2021 09:03:57 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

> The test fails in CI testing citing expected "rededited" but found 
> "redEDITED", which seems to point to fact that either there is a CAPS_LOCK 
> key switched on or some other test did not use SHIFT key corectly  ie, 
> pressed but not released.
> 
> Considering many more tests would have failed if CAPS_LOCK is turned on, I 
> tried to find if some tests uses SHIFT key mistakenly and it seems 
> JRadioButton test has press/release order wrong and it uses SHIFT. Rectified 
> that.
> 
> In addition, corrected some known CI issues ie waiting after frame is made 
> visible, made frame to centre. Along with that, also modified testcase to 
> check lowercase string. Since the original JDK-4275046 issue is about newly 
> entered text is made part of cell or not, it does not matter if it's in 
> lowercase/uppercase and if such CAPS_LOCK or Shift key problem happens again, 
> this test will not be affected.
> 
> CI run for several iterations running these 2 tests one after another in all 
> platforms is green.

This pull request has now been integrated.

Changeset: cec6c068
Author:    Prasanta Sadhukhan <psadhuk...@openjdk.org>
URL:       
https://git.openjdk.java.net/jdk/commit/cec6c068b03d890312e50b448fbc26102c635249
Stats:     21 lines in 5 files changed: 12 ins; 7 del; 2 mod

8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value 
in the cell: 'rededited' but found 'redEDITED'."
8257540: javax/swing/JFileChooser/8041694/bug8041694.java failed with 
"RuntimeException: The selected directory name is not the expected 'd ' but 'D 
'."

Reviewed-by: serb

-------------

PR: https://git.openjdk.java.net/jdk/pull/5079

Reply via email to