Hi Con, Thank you for your patch. I've reviewed it and committed it to subversion, its good to have a fix for the datastream name issue I know your not the first to come across it. There should be a new release available; sword-fedora-1.3.1 which includes this fix.
Cheers Glen Robson National Library of Wales On 11 Jul 2011, at 08:33, Conal Tuohy wrote: > A couple of weeks ago I reported a bug in the Fedora SWORD > implementation, and today I submitted a patch to fix the bug: > > https://sourceforge.net/tracker/?func=detail&aid=3339741&group_id=208296&atid=1005125 > > Could one of the sword-app committers review the patch? > > We noticed the bug when attempting to deposit an application/zip package > containing files with spaces in their names. What happens is that the > SWORD server generates a FoxML document from the files contained in the > zip file, and coerces the file names into XML NCNames. The existing > implementation, however, doesn't expect spaces in the file names, and > hence it generates invalid XML names, so the FoxML fails schema > validation, and the deposit fails. My patch includes a more robust (but > also more lenient) munging of filenames to NCNames. Unlike the old > implementation, the patched version allows any filename which is a valid > NCName (including filenames like "㮍"), and removes only characters > which are not allowed in NCNames. > > Regards > > Con > > -- > Conal Tuohy > eResearch Business Analyst > Victorian eResearch Strategic Initiative > +61-466324297 > > > ------------------------------------------------------------------------------ > All of the data generated in your IT infrastructure is seriously valuable. > Why? It contains a definitive record of application performance, security > threats, fraudulent activity, and more. Splunk takes this data and makes > sense of it. IT sense. And common sense. > http://p.sf.net/sfu/splunk-d2d-c2 > _______________________________________________ > sword-app-tech mailing list > sword-app-tech@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/sword-app-tech ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ sword-app-tech mailing list sword-app-tech@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sword-app-tech
