I havn't written the code :) It was Nikolay, a new coder in the BibleTime team. He's really a help for me! Adding the Encoding line would be cool. The best would be to offer two file for one language, one in UTF8 and on e (if possible) in the normal encoding like we have it now. If an appliocation uses ICU it sould use the UTF8 files, because they're much better.
Joachim > Joachim, > After reviewing the patch (most of which was just re-indenting the > current code), it seems that what you are asking is to have > getBookAbbrev first try the normal toupper match, and if none is found, > also try a match without changing the case. Is this correct? I don't > mind this. Eventually, we're hoping to switch the toupper logic to icu > if it is present, and also add an Encoding= to the locale, and this > should allow better handling of locales. I'll add this logic to the > getBookAbbrev method (without the 'goto' statement :) ) if this will > help, for now. > > -Troy. > > Joachim Ansorg wrote: > > This is a patch to make locales, which are currently not working work > > better (e.h. russian). > > > > Troy, can you please review this and post your ok or criticism? > > > > Joachim > > > > ---------- Forwarded Message ---------- > > > > Subject: Re: bibletime stuff > > Date: Sun, 25 Aug 2002 21:54:54 +0000 > > From: "John Being" <[EMAIL PROTECTED]> > > To: [EMAIL PROTECTED] > > > >>>Currently it doesn't work out of the box (for the same reasons as Hebrew > >>>translation, and most other non-West Europian encodings), I would fix it > >> > >>if > >> > >>>nobody else gonna do that. > >> > >>Does the attached file work better now? I hope it does, because on my box > >>it > >>works ok (choosing the books of the list in BibleTime works, at least I > >>think > >>it looks like russian :) > > > > Well not for me - Sword gives bunch of messages like this: > > Book: Иеремия does not have a > > matching toupper abbrevs entry! book number returned was: -1 > > Book name is in Russian. I created dirty hack(see attachment) for Sword > > that makes it working (but slows stuff down for affected locales). > > Probably it should be in CVS until we'll get better uppercase logic. > > > > > > Nikolay. > > > > > > > > > > > > _________________________________________________________________ > > Chat with friends online, try MSN Messenger: http://messenger.msn.com > > > > -------------------------------------------------------
