Yes, please test anywhere you can.

What targets do you mean? Please test and provide the options passed
to cmake and environmental variables set as well as cmake version.

I don't have access to Mac/Windows. So yes, please test as much as possible =)

On 22 March 2012 23:57, Greg Hellings <[email protected]> wrote:
> I'll have to look more closely at this patch when I get back to a
> Linux machine. Most of it I will probably apply but it looks like you
> failed to account for the fact that there are two separate targets
> that need to be set. This should also improve build on Windows and Mac
> targets as they require the suffix rules you've included.
>
> --Greg
>
>
> On Thu, Mar 22, 2012 at 5:58 PM, Dmitrijs Ledkovs
> <[email protected]> wrote:
>> Dear all,
>>
>> this patch improves cmake buildflags handling
>>
>> * default flags provided for various configurations
>> * environmental flags are appended to the end
>>
>> this allows to arbitrary experiment with CXXFLAGS / CFLAGS / LDFLAGS
>>
>> Reviews and comments are welcome.
>>
>> Please consider applying this to trunk or tell me why not.
>>
>> --
>> With regards,
>>
>> Dmitrijs Ledkovs
>>
>> _______________________________________________
>> sword-devel mailing list: [email protected]
>> http://www.crosswire.org/mailman/listinfo/sword-devel
>> Instructions to unsubscribe/change your settings at above page
>
> _______________________________________________
> sword-devel mailing list: [email protected]
> http://www.crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page



-- 
With regards,

Dmitrijs Ledkovs

_______________________________________________
sword-devel mailing list: [email protected]
http://www.crosswire.org/mailman/listinfo/sword-devel
Instructions to unsubscribe/change your settings at above page

Reply via email to