some thoughts below:
On 20/01/2013, at 3:28 AM, Troy A. Griffitts <scr...@crosswire.org> wrote:
> I've done my part and changed one more tag. transChange has been upgraded
> from:
> <i></i>
>
> to:
>
> .transChangeSupplied {
> font-style: italic;
> }
>
> <span class="transChangeSupplied"></span>
>
> More changes welcome.
>
> Nic, you mentioned doing similar work on your own copies of our filters. Any
> experience you'd like to share?
I have been (mostly) ruthless and done away with the crud that is probably from
HTML2 days? ;)
I can't see the point of having all the markup tags there when it could be
simply one class surrounding the <a> tag.
>From osishtmlhref.cpp (my version) I have changed strong's links (line 67) to:
buf.appendFormatted("<a
href=\"passagestudy.jsp?action=showStrongs&type=%s&value=%s\"
class=\"strongs\"><%s></a>",
from
buf.appendFormatted("<small><em class=\"strongs\"><<a
href=\"passagestudy.jsp?action=showStrongs&type=%s&value=%s\"
class=\"strongs\">%s</a>></em></small>",
Similar stuff is done for the morph's links.
Also for the showNote stuff (line 256) I have similarly removed the <small> &
<sup> tags. :P
buf.appendFormatted("<a
href=\"passagestudy.jsp?action=showNote&type=%c&value=%s&module=%s&passage=%s\"
class=\"%c\">*%c%s</a>",
Oh, plus I went ahead and added support for OSIS underline stuff to
osishtmlhref.cpp if you're interested in incorporating that back into SVN?
I actually have it on my todo list to send a diff for it and some tweaks to
stringmgr.cpp, but if you take a look at
https://bitbucket.org/niccarter/pocketsword/src/70a056c42a45a2babe5bffbd3859596aeade867c/externals/sword/src/modules/filters/osishtmlhref.cpp?at=default
you can decide what you want to pull across yourself rather than I send a
patch just for the underline stuff?
Does that help?
[aside: I took a raw dump of the HTML thrown out by the filter and tried to
validate it as html. I started cleaning up what was produced (by an OSIS
module) and then gave up. But that is why I have the "&" stuff in there, as
that is what it "should" be.]
>
> Bibletime, same. I know you guys have had stuff styled for quite some time.
>
> Would ultimately like to get this filter set to something we all can share
> and improve.
>
> Troy
>
>
>
> _______________________________________________
> sword-devel mailing list: sword-devel@crosswire.org
> http://www.crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page
_______________________________________________
sword-devel mailing list: sword-devel@crosswire.org
http://www.crosswire.org/mailman/listinfo/sword-devel
Instructions to unsubscribe/change your settings at above page
