On 07/31/2013 04:40 PM, Jaak Ristioja wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 31.07.2013 17:08, Troy A. Griffitts wrote:
I've added the new method signature as you've suggested (slighted
different to match the preStatus method), and deprecated the
statusUpdate method. Oddly GCC doesn't warn me that I've
overloaded the deprecated method in the installmgr utility. I'm
calling the deprecated method from a default implementation of the
new method, so if you don't override the new method (which most
people won't yet), they'll still get their status updates.
I'm not sure whether using unsigned long instead of size_t (or even
instead of curl_off_t itself) is a good idea, since curl_off_t used in
the new callback interface of curl might either be a long, a long long
or a ssize_t (POSIX) depending on the widths of long and long long.
Look for CURL_TYPEOF_CURL_OFF_T in /CMakeLists.txt in curl:
https://github.com/bagder/curl/blob/master/CMakeLists.txt#L400
So in case we're using unsigned long, but curl uses unsigned long long
as curl_off_t, it might happen, that Sword progress indication for
sizes larger than 4 GB will be incorrect (if sizeof("long long" or
"ssize_t") > 4 && sizeof(unsigned long) == 4).
Well, if I thought we'd ever have a module > 4GB, I'd think harder about
this.
About the default implementation of update() calling statusUpdate() in
SVN 2932, I think you might have missed some pragmas. I think
something like this is better:
#if defined(__GNUC__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif
statusUpdate(totalBytes, completedBytes);
#if defined(__GNUC__)
#pragma GCC diagnostic pop
#endif
Thanks for pointer. I didn't know about diagnostic push. Instead I
accounted for this by moving the method to the end of the .cpp
Troy
Blessings,
Jaak
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
iQgcBAEBAgAGBQJR+SHNAAoJEEqsYmEt1rCOHC0//0T6fDrQ7zrIh6uao9UuTeXT
7DXiZqEkGbu2lZSPVLohNtSCt/gu0dkzxPYZylik4snUJ18twPFuEuqqWA+EnX3q
MjAeoJ9Y/CenWFvmZp5LDRS05143GrhKZKbOJj+gyKsKAfYiJ8RGn9DKkP9HGJm/
h+mYRPzUNMtvlhjmO7593Oi3mZYWbXVBio5KTb8M+C8nlBTu2RCj5Ta7vOF57mRq
djj2jaNJ/xfPpEjDEMRq5PBT4frOeBRQKBBwU+Z2JxEujuANO8wjrmIEhmVWbOLO
1+5xfQYsp5tH3rr/cdNtZGnXe2BsNYPpe4hZcLaE9bWw3kEEqVB84HIs9NfcLyFm
tdNi5mZrT1Em5NLO3oU8Zs7wOfrstEUwdk7w+wCHryj6JbpEHZWdCG37iaJKPnxX
GzQS2xuIJj48KSF1ZkIF5rlNJD92m1Kf+h42yIKnMya55bdGDbREK0FNsgxA17L/
fTKB5mEleIlPCLRno6BuLkBKZ4YlRbgnbnqOoTmRS49aJYgn6Sc4UY4QKgz6emXD
haHMlysMIOXSaC6jnlwsMNxt78AT+1HJ4lD/hnCNLKZZPPMNhC4ytMx6H3Ubaxza
8zKaJ1OOUjjFhj4nhkyq/fKexMR/0VdBMlEakuI/730Jb5baIVEbUuwImTj25vyc
9erx3R9NPK+/U8PnfE/jcFiB/t33+jC7EsrkT/07G1ua8Lt1TJivD8oru7R6JY1p
hfONEWyiDDuvo8gJhCXY6s9JNJ2MIeGdQPuirGX14PkqOpXku5ccTJ4tduJ9XibG
DB7dATa1jGALbuSe0zGWzWK4czp/jrMbZTwzaomS/x+XB78TWba5Z1rEKdZaXV8d
3Fv7dgynrXeCGMfCJRQ2ZYEalJQdpzpjvfRzl0RVBHUJ9n6cCTViSAamDgggusw0
Bq4mA5zaW4mPVpVLbEt2/k+0Edfa6YkstKxOu83vDadCqLFOelijrE4bil6Fi60c
2Q4aLGlQVia9VdcgI4H/6NkwvqplMxR1ytDkLguJ7ydx8UxtIYC1AqhyhWqHccpP
xgvEj+j7x5aaTQtlEp/LK/hoXIAWU2rYQz5d9qM/GC5o7+RB2YwsteH9EZ1JLwt4
Hy0bUAAtidZJHKVCtE86VJ67lPubLhCidQ9AbqKmmkdvI9Hzg2WqIynluCGb2JZE
zWHH8saHXbv7G9priQ9iBcd7LIaYYDCsFw832DBS8p9QKQDTPSQvFBf+3LtZK47D
c+E0c+3mYFYhKK2F4jXk5JAcwkzWFgjLLJNrI7BfmkY5k66G7YNWMyOicE7g+72B
WcfxE01AkNy7VIe9MCVemuyydw4xIaOIov79USgv6Qvz0Lj7G03fAIrEfyd/3nGg
IB4R8U9XzGHWmOeZ5dNC52/ZqUT8uXfEWTJTcrs1PiGBwwhywxzys8k4i2m+EpID
jsSzP0qGptLOdD8g9WXgNFjURy0IA2hWzBQ59DqOY1U97nwWEZobT+55/2Gf0WfZ
6mhTAHHuprq4Iwy22kYLvmlImSw3dYQqN488YcCwmklZ80rzpdhn9eYB82AtNY7Q
LFHklHZPEXC7Be6wG/KGh0DK2wg3kmYWZyVUSPYuIxO/p7+OiUyep+qzs0xcXGHY
P2lyPMe26xNGMZXbrPmKzHJnx6anvo1zP67cCbXu/AA0sYGYlLIV7DCeU22C7Eg2
qdGgmGOtnNhj04FIXx4JQgwEKlQ6kZLgWXsEVk7I71QtCKZUZTY6CWO/Zv4GMXwo
E39A6RyNEu2qbhna1Z3sdxdSVWsNFrdigkAIqr2sNWiBHUX7fqLLSy8Ur5H/zjnY
K4+AiQ77YB02//pJfOZvQyKlsmQS8GU2RE/WWL2HrA8/L08H1TDtt/O+oH1bt+tx
TqzyaJg2mttg33BQ5osN0CoNgfPbwsmdKtG2rmVUpY/w6kEgDNEjOA2BVHGElHbF
2ZB1uWJyHPYoH+08Gejzhxe/jNd1NObXc1EPndcUrqHZn1uOx8POG9Mhb49H4Sqy
6dJ5KB0nwuXmamGendOrHeJwX8UC5TMXXh0YldYlFGPAQzraDkZOkR/AHOmyMHQv
hGcD0Y0IvyW7jUZGKphlp2dN6sr6Jst5yyB9zxBg4IuT2vqnnxfAlnd2fJeyCWdt
8iiw1cTY0nveJZyeTXo74XFJTOzajqI/yFPzBO125j2fK6W8oQj91UgvAOfnOdTo
zBWw7E5kWpdBbdBM7cpeHiNQByV7JzgJxFrC09LmZd+1ykvZUoxxU8KFH5MJ2p8f
m3t0/7OJpiR/9XVhlSYUzWbnmIxG5l87ZgxAMmzOj5l+u4xMmb8HAoRbc6ve0uTp
r2f7Je5sbryNa3X2RY/odX1sJZG8pFn5zma9Q9XmW6FiMWfjO2xNt6DuIFUHyNjo
CDwRHmiq1d+t190AsFDPQU/Y0F7Tm64JBuLzakd/O4G+p0aL870CfsdGL0w4opNm
6GFuYmHcjHyPKHUMeRr3g5jCDshkw3VGw2flQvlVdjTichx16+gYqUATnOKEOJKE
Rr2X5HnASfXUcltQYg0Hz2aNMBELbNvJnv4bkoJjSJErPgXvpH9MrHh0Ko+C5Tb8
dy08dC6Xq239Lmq/jCoVdQ8KzKFEQcMGG/oNRn1GQ3d+jO7eGkJIQ6/xTzzkgy6w
7YDkA89vdyxWGHmPvAqz4rQuooWz6ChYFs5YlWeDGAlday5zVJ11zvyFc8a3tzgR
uQ1cnoxgPIUKdSd6+Ych
=qmq6
-----END PGP SIGNATURE-----
_______________________________________________
sword-devel mailing list: sword-devel@crosswire.org
http://www.crosswire.org/mailman/listinfo/sword-devel
Instructions to unsubscribe/change your settings at above page
_______________________________________________
sword-devel mailing list: sword-devel@crosswire.org
http://www.crosswire.org/mailman/listinfo/sword-devel
Instructions to unsubscribe/change your settings at above page
