On 1/16/2014 7:35 AM, Костя Маслюк wrote:
> I would assume this requires a change to function signatures, so it's
not going to appear in 1.7.x at all.
In your mouth it sound like that it going never appear in Sword. Patch
only add parameter with default value to one public function. There is
no problem to revert and make some work in private part of class so it
will be absolutely abi compatible.
My understanding was that you were asking about the versification
mapping code going into 1.7.2 or 1.7.x specifically, like you were
asking about the lexicon fix. If that wasn't your intent, there's no
real issue.
Changes to function signatures won't preclude the inclusion of your
patch in 1.8.0 or later.
> I haven't looked at the code, but the idea of mapping between
versification systems (not versifications of particular translations but
versification systems, as we define them) is completely ridiculous.
I know that several translations could have different markup in some
places even if they use same versification system in Sword, so it is
impossible to provide perfect result on versification system level.
I just would like to highlight that there is no technical problem to
make my solution to work on per translation level.
No one is against mapping between versifications to allow lookup using
alternate versification systems, so if it is possible to improve your
solution so that it works on a per-translation level, I think that would
be very helpful.
With that, most of the editions & translations we distribute that use
non-KJV versification systems can be mapped to/from. And the remainder
will be as un-supported as they currently are (which is better, in my
view, than being "supported" with incompatible data).
--Chris
_______________________________________________
sword-devel mailing list: sword-devel@crosswire.org
http://www.crosswire.org/mailman/listinfo/sword-devel
Instructions to unsubscribe/change your settings at above page
