hmm..i'd be interested in seeing what you did before commenting anything
more.
i believe ketan reverted the changes. i suggest creating a different branch
and checking it in there.
On Tue, Jul 1, 2008 at 12:38 AM, Hans Schwaebli <[EMAIL PROTECTED]>
wrote:
> Concerning debugging I see no change between the two solutions.
>
> In fact you can more easily debug if the runBare method is overriden in my
> eyes since you see more clearly how the tests are run.
>
> Automating it is more easy too, since one could simply start the tests like
> any other JUnit Plug-in Test. Fewer dependencies and less unneccessary
> complexity in my eyes.
>
>
>
> --- On *Tue, 7/1/08, Somesh Sasalatti <[EMAIL PROTECTED]>* wrote:
>
> From: Somesh Sasalatti <[EMAIL PROTECTED]>
> Subject: Re: [SWTBot-users] Major changes with SWTBot tests.
> To: swtbot-users@lists.sourceforge.net
> Date: Tuesday, July 1, 2008, 3:28 AM
>
>
> I'd be interested to know how you debug if you run your tests in the UI
> thread. It could get more challenging that what it is right now.
> I am using swtbot only to test Eclipse plugins, hence will stick to the old
> way as i have it working.
>
> can i suggest using another branch for experimenting with running them in
> the same ui thread and porting it over to the main trunk only after it has
> been tested and used by some pilot users. that way, all the old stuff will
> still work and we'll be able to benefit from other bug fixes.
>
> On Mon, Jun 30, 2008 at 11:47 PM, Ketan Padegaonkar <
> [EMAIL PROTECTED]> wrote:
>
>> Here are the new findings:
>>
>> On 01-Jul-08, at 11:56 AM, Ketan Padegaonkar wrote:
>>
>> >> I tried it out and now I can't run any tests. I tried running my
>> >> older Run Configuration that worked before the upgrade (SWTBot
>> >> Runner, JUnit 3). That failed with an illegal Thread acess
>> >> excpetion. Then I created a new run configuration using the JUnit
>> >> Plugin Tests. Setup for Junit 3 and that just reports terminated
>> >> before even running.
>> >
>> > Most SWTBot unit tests run fine, I've not looked at the plugin tests
>> > for now, and will do so today.
>>
>> All unit tests for eclipse plugins fail. Tests run on the UI thread,
>> and dialogs that have an event loop inside them block the execution of
>> tests. Hans have you seen this behavior ?
>>
>> >> Should it be reverted?
>> >
>> > The new approach is a very good approach (thanks to Hans) and if
>> > things break badly, we could take some efforts to fix this, rather
>> > than a slew of questions from newbies. We could definitely revert
>> > this if things break *way* too much to a point where this is not
>> > repairable.
>>
>> I'm reverting to the previous revision where at which the patch was
>> applied. The details of the change and the patch can be found here for
>> future reference: http://fisheye3.atlassian.com/changelog/swtbot/?cs=815
>>
>> -- Ketan
>>
>>
>> -------------------------------------------------------------------------
>> Check out the new SourceForge.net Marketplace.
>> It's the best place to buy or sell services for
>> just about anything Open Source.
>> http://sourceforge.net/services/buy/index.php
>> _______________________________________________
>> SWTBot-users mailing list
>> SWTBot-users@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/swtbot-users
>> http://swtbot.org/ - a functional testing tool for SWT/Eclipse
>>
>>
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://sourceforge.net/services/buy/index.php
>
> _______________________________________________
> SWTBot-users mailing list
> SWTBot-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/swtbot-users
> http://swtbot.org/ - a functional testing tool for SWT/Eclipse
>
>
>
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://sourceforge.net/services/buy/index.php
> _______________________________________________
> SWTBot-users mailing list
> SWTBot-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/swtbot-users
> http://swtbot.org/ - a functional testing tool for SWT/Eclipse
>
>
>
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
SWTBot-users mailing list
SWTBot-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/swtbot-users
http://swtbot.org/ - a functional testing tool for SWT/Eclipse
