Fixed in 1.0 and trunk. Thanks, Fabien
Tamcy wrote: > Hello devs, > > Allow me to shamelessly ask whether my submitted ticket can be > included :) > > http://trac.symfony-project.com/trac/ticket/1851 > > This patch allows consistency of __() behavior no matter i18n is on or > off in the settings. > > Currently code like "echo __('Foo', null, 'catalog');" only works when > i18n is on but throws a E_NOTICE if i18n is off because when it's off > the second parameter must be an array, unlike real i18n message source > which detects non-array parameter and convert it to an array. > > I think it is better to make the function behave the same way no > matter of i18n settings, either allowing or disallowing "null" > altogether. And among them I prefer to allow "null" because it's > shorter and cleaner (so sad [] as empty array is not an option). > > My POV is it doesn't break anything and it isn't adding new > functionality (such syntax is supported when i18n is on afterall) I > believe it is also eligible to 1.0 branch. > > Thoughts and comments are welcome. > > Tamcy > > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en -~----------~----~----~----~------~----~------~--~---
