Regarding "out-of-sync"-plugins, we could use a simple option to mark a plugin update as "minor" or "major", and for each new major release, we could either delete old reviews, or allow the plugin owner (or an auditor, panel, whatever we agree to) to delete outdated reviews.
Otherwise, we could explicitly state that reviews are for specific versions. It would be fair to at least do this for major revisions. Anyway, we should keep it as simple and manageable as possible. On 10/12/2007, forkmantis <[EMAIL PROTECTED]> wrote: > > > How about a "user review" system like amazon.com does. Let users > offer a rating, and then allow them to comment on the reasoning behind > their rating. As far as amazon goes, I find that the comments > exponentially increase the value of the ratings. I usually look at > the worst ratings I can find to see what the complaints are. If the > complaints are for reasons that don't concern me, then I usually end > up feeling pretty good about the product. > > "Although the functionality of this plugin is great, I only rated this > plugin 3 stars because the code is ...." > > Also, how do you keep the comments in sync with the plugin? Suppose a > comment/rating inspires a developer to refactor and improve their > code. Negative comments/ratings may become invalid. Do you link > comments to specific revisions/versions of the plugin, or maybe allow > user moderation of existing comments/ratings? > > On Dec 10, 12:32 pm, mozey <[EMAIL PROTECTED]> wrote: > > >I am talking about : > > >- naming conventions (camelCase vs underscores in yml) > > >- decoupling of concerns > > >- Test Driven Development > > >- Documentation > > >- Code reusability > > >- Design patterns IF NEEDED > > >- etc ,,,,,,,,,,,,,,, > > > > So i guess, back to the original question, i'm not aware of such > > document, but YES, MUCH needed, by a show of hands, who thinks we NEED > > this?!?!?! > > > > +1 > > > > On Dec 10, 10:39 am, Charley Tiggs <[EMAIL PROTECTED]> wrote:> > Hassen, > > > > > You make my point. That's why I suggested we clarify what "quality > > > of code" means. Too often, the focus is on formatting when that's > > > not really the issue. > > > > > Charley > > > > > On Dec 10, 2007, at 11:05 AM, Hassen Ben Tanfous wrote: > > > > > > Let's clarify something, when I am talking about "quality of code", > > > > I am not > > > > thinking about indentation. Any IDE can fix the indentation of your > > > > files in > > > > a second. > > > > > > I am talking about : > > > > - naming conventions (camelCase vs underscores in yml) > > > > - decoupling of concerns > > > > - Test Driven Development > > > > - Documentation > > > > - Code reusability > > > > - Design patterns IF NEEDED > > > > etc. > > > > > > Complaining about indentation and brackets is pointless. You like > > > > using one > > > > bracket per line, good for you. It takes a second to format all my > > > > files > > > > using the indentation I like. > > > > > > On Dec 10, 2007 11:59 AM, Charley Tiggs <[EMAIL PROTECTED]> > wrote: > > > > > >> On Dec 10, 2007, at 10:54 AM, Ian P. Christian wrote: > > > > > >>> mozey wrote: > > > >>>> give it the "Symfony stamp of approval" > > > > > >>> Good idea in principle - doubt many people will have time to do > > > >>> this though. > > > > > >>> Perhaps the rating system needs to have different ratings, for > > > >>> example... > > > > > >>> ease of use: > > > >>> features: > > > >>> quality of code: > > > >>> extensibility: > > > > > >> I support this approach, with the exception of "quality of code". > > > >> It's too subjective unless we have some explicit guidelines that > > > >> define what "high quality" means. Just because I choose to use > > > >> double spacing, it doesn't follow that the quality of my code is > > > >> bad. That's a personal preference of the developer, not a sign > that > > > >> the code is bad. > > > > > >> Charley > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en -~----------~----~----~----~------~----~------~--~---
