Fabien POTENCIER wrote: > You can't just add a feature in trunk just because you have a need for it: > > * All new features must come with unit tests. The new > form/validator/widget framework has 100% code coverage. > * As we now have a 1.1 branch, changes must go to the 1.1 branch and > then ported back to the trunk. > * Try to respect symfony coding standards. > > So, even if I think this is a reasonable feature to add, I've reverted > the change. > > Fabien > > P.S.: same goes for r6589: coding standard, backport to 1.1 branch and > associated ticket has to be closed.
Thanks for sorting out r6589. I might be looking at the wrong coding standards, is this what you are referring to? http://trac.symfony-project.com/wiki/CodingStandards Right at the bottom there, there's an example showing string being concatenated with a space either side of the ., just how I had it - so I think that page needs updating? Also - what was wrong with the CS on the getValue() method I added? The function implementation was a slightly copy and paste from the function above it, and I can't figure out what I did wrong there :) Should I improve the tests, and commit this to the 1.1 branch and trunk - do you feel it's worth adding? What is the best way to handle issues like this in the future - is emailing the dev list with the suggestion and awaiting feedback adequate? Thanks, Ian --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en -~----------~----~----~----~------~----~------~--~---
