I never use the per-action classes and I think there is never a good 
reason to use them.

The execute() or executeXXX() method for an action always contain very 
little code (... if not, then you probably need to refactor your code 
and move some parts to the model or to helper classes). So, it makes 
sense to only have one action class for all methods.

My point is: do we really need to keep them around (except for BC 
reasons)? What about deprecating the per-action classes support for 
symfony 1.1 and remove them in 1.2?

Fabien

--
Fabien Potencier
Sensio CEO - symfony lead developer
http://www.sensiolabs.com/
http://www.symfony-project.com/
Sensio Labs
Tél: +33 1 40 99 80 80


Ian P. Christian wrote:
> Imagine you're using per-action classes.  2 modules, 'moo', and 'cow'.
> 
> apps/frontent/modules/moo/actions/indexAction.php:
> 
> class indexAction extends sfAction
> 
> apps/frontent/modules/cow/actions/indexAction.php:
> 
> class indexAction extends sfAction
> 
> 
> See the problem yet?
> 
> You will encounter problems when you do something like this:
> 
> 
> $this->forward('moo', 'index') from the index action of cow!
> 
> 
> The names of per-action classes should probably be 'fully-qualified'.
> 
> indexMooAction, and indexCowAction perhaps?
> 
> I suggest this change for sf1.1
> 
> Thoughts?
> 
> 


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/symfony-devs?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to