Okay, I have made a patch for symfony v.1.0.16. This patch will (I
hope) move the directory & file permission settings to the
constants.php file where the user can modify them in one spot.

Since I can't add an attachment here, I'll put it in the forum here:
http://www.symfony-project.org/forum/index.php/t/13059/

Now I have a question about the umask setting I see in the symfony
code.
In php_dir/symfony/cache/sfFileCache.class.php, I see this:
    // create cache dir if needed
    if (!is_dir($cacheDir))
    {
      $current_umask = umask(0000);
      @mkdir($cacheDir, sfConfig::get('sf_directory_perm'), true);
      umask($current_umask);
    }

This looks wrong to me. If $current_umask = umask(0000), then the last
line would be 'umask(umask(0000))'.
Am I crazy?
I see other umask references in the code like that.
Maybe it should be:
$current_umask = 0000
? Or to bundle up these permission settings in one spot, maybe create
'sf_umask_setting' in constants.php, same as sf_directory_perm??
What do you think?
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/symfony-devs?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to