I suppose it would be a BC break for anyone who is already using instanceof() to check whether something is one of sfWidgetFormInput's subclasses. But isn't this the sort of very minor incompatibility that would almost have to be allowed for 1.3 to differ meaningfully from 1.2?
On Wed, Apr 15, 2009 at 7:08 PM, Kris Wallsmith <kris.wallsm...@symfony-project.com> wrote: > I considered this option but I see it as a BC break because > sfWidgetFormInputPassword (for instance) would no longer extend > sfWidgetFormInput. > > -- > Kris Wallsmith | Community Manager > kris.wallsm...@symfony-project.com > Portland, Oregon USA > http://twitter.com/kriswallsmith > On Apr 15, 2009, at 3:51 PM, Jonathan Wage wrote: > > So right now we can't identify a normal input field by doing instanceof > sfWidgetFormInput because all the other widget types extend that? If so, > what about this so that it maintains BC and you still use sfWidgetFormInput. > > 1.) Rename sfWidgetFormInput to sfWidgetFormInputBase(or something similar) > and make it abstract. > 2.) Create new class named sfWidgetFormInput that extends > sfWidgetFormInputBase and is empty. > 3.) Change all classes that used to extend sfWidgetFormInput to extend > sfWidgetFormInputBase > > If I am not mistaken this way it is BC? > > - Jon > > On Wed, Apr 15, 2009 at 8:13 AM, Tom Boutell <t...@punkave.com> wrote: >> >> I agree, this is a smart choice. >> >> On Wed, Apr 15, 2009 at 3:27 AM, Dennis Benkert >> <spinecras...@googlemail.com> wrote: >> > >> > Nice improvement. +1 for it. >> > >> > - Dennis >> > >> > 2009/4/14 Kris Wallsmith <kris.wallsm...@symfony-project.com>: >> >> I've just opened a ticket on Trac to add a sfWidgetFormInputText class >> >> to >> >> the 1.3 branch. The addition of this class will set text fields on the >> >> same >> >> level as password and file upload fields and allow developers to >> >> identify >> >> text fields using instanceof sfWidgetFormInputText. The current >> >> sfWidgetFormInput class would ideally become an abstract class that >> >> does not >> >> specify a type attribute, but I've left it intact for purposes of >> >> backward >> >> compatibility. >> >> http://trac.symfony-project.org/ticket/6288 >> >> My use case involves sfViewableFormPlugin, which allows devs to >> >> globally >> >> modify view-related aspects of form objects from config/forms.yml. This >> >> can >> >> be done based on widget class. The addition of sfWidgetFormInputText >> >> would >> >> make the following common practice very easy: >> >> widgets: >> >> sfWidgetFormInputText: >> >> attributes: >> >> class: text >> >> >> >> Please post your thoughts here or on the ticket. >> >> Thanks, >> >> Kris >> >> -- >> >> Kris Wallsmith | Community Manager >> >> kris.wallsm...@symfony-project.com >> >> Portland, Oregon USA >> >> http://twitter.com/kriswallsmith >> >> >> >> > >> >> >> > >> > > >> > >> >> >> >> -- >> Tom Boutell >> P'unk Avenue >> 215 755 1330 >> punkave.com >> window.punkave.com >> >> > > > > -- > Jonathan H. Wage > Open Source Software Developer & Evangelist > http://www.jwage.com > http://www.doctrine-project.org > http://www.symfony-project.org > > > > > > > > -- Tom Boutell P'unk Avenue 215 755 1330 punkave.com window.punkave.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to symfony-devs@googlegroups.com To unsubscribe from this group, send email to symfony-devs+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en -~----------~----~----~----~------~----~------~--~---
