hmmm, I consider linbreaks very fragile, and I fear that the tests might fail to often because of this. I think that fix_linebreaks method is fine for us (us meaning symfony core developers).
Fabian On May 16, 2009, at 11:52 AM, Kris Wallsmith wrote: > I'm concerned this solution presents maintenance concerns. I don't > see developers including this function in their tests (I don't think > they should have to, honestly). How about we patch it into lime with > a parameter to disable it? > > Or, would the problem be resolved if we enforce Unix linebreaks in > the core and ask all devs to set svn:eol-style to native? > > Which is the right solution? > > Thanks, > Kris > > -- > > Kris Wallsmith | Community Manager > [email protected] > Portland, Oregon USA > > http://twitter.com/kriswallsmith > > On May 15, 2009, at 8:36 PM, Pascal wrote: > >> >> Hi, >> >> I already noticed the linebreak problem in heredoc and fixed it >> converting test files in unix format (yes there are plenty files in >> symfony core in windows format :/) >> >> [MA]Pascal >> >> On Fri, May 15, 2009 at 10:01, Fabian Lange >> <[email protected]> wrote: >>> Hi Kris, >>> I was considring adding the linebreak thingy to lime, however I >>> think that >>> the dev needs explicitly to invoke linebreak fixing. >>> So no magic inside the$t->is() >>> >>> And as general purpose method into lime.. well it is somehow >>> hardcoded to >>> symfony core dev requirements. >>> >>> I am not sure, but not against it :-) >>> Fabian >>> >>> >>> On Fri, May 15, 2009 at 11:10 AM, Kris Wallsmith >>> <[email protected]> wrote: >>>> >>>> Hi Fabian, >>>> Thanks for doing this. Can we patch lime with this functionality >>>> rather >>>> than adding a global function? >>>> Kris >>>> >>>> -- >>>> Kris Wallsmith | Community Manager >>>> [email protected] >>>> Portland, Oregon USA >>>> http://twitter.com/kriswallsmith >>>> On May 15, 2009, at 10:59 AM, Fabian Lange wrote: >>>> >>>> Hello dear devs, >>>> recently worked on making the symfony tests running perfect on >>>> windows >>>> boxes. >>>> Basically there were two activities: >>>> a) Using the fix_linebreaks function i added to the unit- >>>> bootstrap, which >>>> converts all kinds of linebreaks into \n. This is helpful, >>>> because when some >>>> expectation string is written in heredoc, it is highly affected >>>> by the >>>> system linebreak char(s). symfony will generate linebreaks always >>>> as \n. >>>> b) on one of my windows boxes I have a permission glitch when >>>> cleaning >>>> logfiles. In fact I found out exceptions thrown in the cleanup >>>> process >>>> caused a fatal error. I added a try/catch in the cleanup to >>>> migitate this. >>>> >>>> Because those two were only relevant for symfony core >>>> development, only >>>> affecting windows so far (my mac and debian dont make a noise) >>>> and I am a >>>> bit lazy today, I only applied it to symfony 1.3, which will be >>>> the mostly >>>> developed symfony version from now. >>>> >>>> So unless someone really insists, I will not backport them :-) >>>> >>>> Fabian >>>> >>>> >>>> >>>> >>>> >>>> >>> >>> >>>> >>> >> >> >> >> -- >> Pascal >> >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en -~----------~----~----~----~------~----~------~--~---
