I don't think you need to list all the tests that reference a ticket. Using trac allows us to reference the ticket in the changeset message, and then the ticket has also a reference to the changeset. That's quite enough if you ask me.
For symfony, I prefer to add the needed tests in the existing test files and add a reference to the ticket. Fabien -- Fabien Potencier Sensio CEO - symfony lead developer sensiolabs.com | symfony-project.org | fabien.potencier.org Tél: +33 1 40 99 80 80 Frank Stelzer wrote: > I would make it in this way, too (if i would be in your position :P). > But why not creating an additional document, with a simple table > including the ticket data and the according tests? So you would have the > possibility to see all "ticket tests" at a glance, if you need this > information. > > Frank > > > Am 05.06.2009 um 07:42 schrieb Kris Wallsmith: > >> I'd prefer the tests be organized by class rather than ticket. The >> current test suite includes an inline comment just above the tests >> that references any pertinent ticket. I think things will be easier to >> understand this way. >> >> Thanks, >> Kris >> >> -- >> >> *Kris Wallsmith* | Community Manager >> [email protected] >> <mailto:[email protected]> >> Portland, Oregon USA >> >> http://twitter.com/kriswallsmith >> >> On Jun 5, 2009, at 6:25 AM, Lucas Stephanou wrote: >> >>> >>> I was reviewing doctrine test directory( know with jwage? :-] ), and a >>> subdirectory ticket can be useful. >>> >>> If ok to Fabien I can put some effort next weeks in doing this, start >>> writing test to ticket without one. >>> so we can do like doctrine? >>> 1.3/ >>> tests/ >>> unit/ >>> ticket/1234Test.php >>> functional/ >>> ticket/1234Test.php >>> >>> >>> another way: had a block comment with related ticktes for give tests >>> example: >>> line 38, sfToolkitTest.php [1.3] >>> was: >>> $t->is('été', true, '::isUTF8() returns true if the parameter is an >>> UTF-8 encoded string'); >>> will be: >>> /* @ticket #1234, #1235 */ >>> $t->is('été', true, '::isUTF8() returns true if the parameter is an >>> UTF-8 encoded string'); >>> >>> >>> 2009/6/4 Jonathan Wage <[email protected] <mailto:[email protected]>>: >>>> I've added 1 test to sfDoctrinePlugin in this way. >>>> >>>> http://svn.symfony-project.com/branches/1.3/lib/plugins/sfDoctrinePlugin/test/functional/Ticket/5269Test.php >>>> >>>> I asked Fabien if this is fine and he said yes. But, I think having >>>> so many >>>> files, one for each ticket would take a really long time to run. Add a >>>> TicketTest.php with a way to include individual little snippets to test. >>>> Maybe through a file named a certain way in a specific location? Like >>>> ticket/1234.php >>>> >>>> Jonathan H. Wage (+1 415 992 5468) >>>> Open Source Software Developer & Evangelist >>>> sensiolabs.com | jwage.com | doctrine-project.org | symfony-project.org >>>> >>>> >>>> On Thu, Jun 4, 2009 at 8:26 PM, Lucas Stephanou <[email protected] >>>> <mailto:[email protected]>> wrote: >>>>> >>>>> Is there tests to tickets, or how we can connect a test case to some >>>>> ticket. >>>>> I knew that doctrine has a aprouch like: >>>>> test/12054test.php (direct test of ticket #12054) >>>>> >>>>> >>>>> >>>>> 2009/6/4 Fabian Lange <[email protected] >>>>> <mailto:[email protected]>>: >>>>>> >>>>>> After my recent update of the I18N data files and fixing the failing >>>>>> test cases *caugh*, I was presented with this green bar: >>>>>> >>>>>> All tests successful. >>>>>> Files=235, Tests=9000 >>>>>> >>>>>> Hooray! >>>>>> But we need more. Perhaps you want to sped a few minutes to add >>>>>> testcases for some of the tickets in Trac? >>>>>> So we get more testcases (even failing ones which we can make passing) >>>>>> which results in a better symfony for us all >>>>>> >>>>>> have a nice day! >>>>>> >>>>>> Fabian >>>>>> >>>>>>> >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Lucas Stephanou >>>>> >>>>> >>>> >>>> >>>>> >>>> >>> >>> >>> >>> -- >>> Lucas Stephanou >>> >>> >>> >> >> >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en -~----------~----~----~----~------~----~------~--~---
