Thanks for putting this together, Max! I've had similar issues with the ->click() method, but I think there may be a way to address them without adding a new method to the sfBrowser API. Allowing a CSS selector to be passed to ->click() would accomplish the same thing but with more flexibility.
I mentioned this to Fabien earlier and he seemed to think there was an even better solution, TBD. In short, let's hold off on committing Max's patch for the time being. Thanks, Kris -- Kris Wallsmith | Community Manager [email protected] Portland, Oregon USA http://twitter.com/kriswallsmith On Jul 15, 2009, at 11:16 AM, Fabian Lange wrote: > > Looks interesting. The refactoring looks good from the diff, and your > new code has testcases :-) > > I will check it and apply to 1.3 tomorrow > > Fabian > > On Jul 15, 2009, at 7:29 PM, Maxim Oleinik wrote: > >> >> Hi all, >> >> I've submited a patch which allows to click by element id. >> I think it is more comfortable than manipulate with "position" >> option. >> Especially if you have different tags with same value. >> >> Please, look at http://trac.symfony-project.org/ticket/6847 >> What do you think? >> >> Мах >> >>> > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en -~----------~----~----~----~------~----~------~--~---
