Thank you Fabian!

On Thu, Aug 6, 2009 at 6:56 PM, Fabian
Lange<[email protected]> wrote:
>
> Thanks for bringing this to our attention. You are right a simple one line 
> fix.
> Commited in r20870
>
> Fabian
>
> On Thu, Aug 6, 2009 at 10:37 PM, Tom Boutell<[email protected]> wrote:
>>
>> Please check out this bug:
>>
>> http://trac.symfony-project.org/ticket/4152
>>
>> It appears that a fix has been committed somewhere for quite a while
>> but it's not in /branches/1.2. Also the patch that's been committed
>> doesn't really address the core issue, which is that when a confirm
>> attribute is present, link_to_function sets up a click handler with a
>> confirm call but doesn't actually unset confirm in html_options. The
>> end result is that a confirm attribute gets output in the HTML (which
>> is invalid), and Internet Explorer assumes that confirm attribute is
>> what you are trying to invoke when you call confirm(). A JavaScript
>> error ensues and the function fails entirely.
>>
>> Calling window.confirm gets around the problem but the real fix is to
>> unset the confirm attribute after setting up the handler.
>>
>> See my comments at the end of the bug for the one-line fix.
>>
>> Simple bug, might go back several versions of Symfony - can we get
>> this one fixed?
>>
>> Thanks!
>>
>> --
>> Tom Boutell
>> P'unk Avenue
>> 215 755 1330
>> punkave.com
>> window.punkave.com
>>
>> >
>>
>
> >
>



-- 
Tom Boutell
P'unk Avenue
215 755 1330
punkave.com
window.punkave.com

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/symfony-devs?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to