Hello, As I told I will propose all the things I made in my Symfony plugin and I think should be in Propel's core. See http://www.symfony-project.org/plugins/nahoPropelOptimizerPlugin/0_0_2?tab=plugin_readme for the full list.
Here I'll talk about the doSelectJoinXXX methods, which do not use the JOIN, but simply adds a silly criteria... PostPeer::doSelectJoinAuthor will execute this query : SELECT * FROM post, author WHERE post.author_id = author.id AND ... Whereas I'd expect it to execute this query : SELECT * FROM post INNER JOIN author ON (post.author_id = author.id) WHERE ... The patch I'll propose will force the following behavior : - Use real JOINS when calling doSelectJoin* - Use INNER_JOIN when FK field is marked as required, LEFT_JOIN otherwise To see the implementation (which is not a patch, but extends PHP5PeerBuilder), look at http://trac.symfony-project.org/browser/plugins/nahoPropelOptimizerPlugin/trunk/lib/SfOptimizedPeerBuilder.php lines 28-42 What do you think about ? --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en -~----------~----~----~----~------~----~------~--~---
