Thanks Kris. The rest of the 1.3 porting process went pretty smoothly except for one more issue:
In Symfony 1.3 the sfRichTextEditorFCK class can't be autoloaded. This seems to be deliberate since it now contains explicit code to require its parent class file... I'm guessing autoload of classes in helpers folders was turned off purposely. That breaks some common implementations of rich text widgets that are floating around. But they would die in Symfony 1.4 anyway. If rich text widgets won't be in Symfony core, they really need to at least be in a core plugin. sfFormExtraPlugin doesn't seem to offer them. I ported the important bits of sfRichTextEditorFCK directly into our own sfFormRichTextWidget class, replacing the old sfRichTextEditorFCK wrapper approach. That class is now in pkToolkitPlugin, so that takes care of anything using our stuff, but something similar should be easily available. The Apostrophe suite, including pkContextCMSPlugin and pkMediaPlugin, now seems to be running well under Symfony 1.3. The changes so far are backwards compatible to 1.2 as far as the plugins go, very nice. The cmstest project did need to be changed in a few small but incompatible ways, so it is now branched: http://svn.symfony-project.com/plugins/pkContextCMSPlugin/sandbox/branches/1.3 I'll be documenting that so people can choose to start with Symfony 1.3. Symfony 1.4 will take a bit more work since we still have a few stray instances of the form helpers here and there. It took us a while to warm up to the idea of using forms for really simple cases like search forms, or our plaintext and rich text CMS slots. It still seems a litttle bit excessive, but not as foreign as it did at first. (pkContextCMS has always had good support for editing slots via real Symfony forms, so we just need to eat our own dog food (: ) On Wed, Nov 25, 2009 at 2:03 PM, Kris Wallsmith <[email protected]> wrote: > I've updated the 1.3 upgrade task to add the class name to the application > filters.yml file. > Thanks for the report, > Kris > > -- > Kris Wallsmith | Release Manager > [email protected] > Portland, Oregon USA > http://twitter.com/kriswallsmith > On Nov 25, 2009, at 8:35 AM, Tom Boutell wrote: > > Trying a 1.3 upgrade of our cmstest project this time. Executive > summary: so far one documentation problem, one possible bug in the > upgrade task, and some PHP 5.3.0 segfaults that don't happen in > Symfony 1.2, which I'll be researching further. > > * * * > > The project:upgrade1.3 task ran smoothly. > > The site then fails with: > > 500 | Internal Server Error | sfParseException > Configuration file > "/Users/boutell/Sites/cmstest13/lib/vendor/Symfony/lib/config/config/filters.yml" > specifies category "common" with missing class key. > > Chasing this down... the > http://www.symfony-project.org/tutorial/1_4/en/upgrade page mentions > deprecations and points to > http://www.symfony-project.org/tutorial/1_4/en/deprecated which says: > > The following classes have been deprecated in symfony 1.3: > > sfCommonFilter: see the "Removal of the common filter" section of the > UPGRADE_TO_1_3 file for more information about the consequences and > how to migrate your code. > > The UPGRADE_TO_1_3 file says: > > Upgrading Projects from 1.2 to 1.3 > ================================== > > The content of this file has been moved online at the following URL: > > http://www.symfony-project.org/tutorial/1_3/en/upgrade > > Which redirects me back to: > > http://www.symfony-project.org/tutorial/1_4/en/upgrade > > Awesome. (: > > Ah, the related documentation actually is there, later in the page > after the link to the other page for deprecation info: > > "Removal of the common filter > > The sfCommonFilter has been deprecated and is not used anymore by default." > > But it is not in the deprecated page with the rest of the deprecations > so I wasted time looking for it in the "right place" before I found > it. That could use a little touching up, especially the link to a text > file that links back to the web site etc. > > This section of the documentation says that the common filter is > automatically removed by the upgrade task. That did not happen. svn > diff says the upgrade task didn't touch > apps/frontend/config/filters.yml. That file currently looks like this: > > rendering: ~ > security: ~ > > # insert your own filters here > > cache: ~ > common: ~ > execution: ~ > > Removing the 'common' line manually... > > That brings my site up, missing the the js and css that would be > loaded by the common filter. I followed the instructions to fix that > in my layout.php and my site came up. > > OK, moving on to trying some real stuff: logged into the cmstest site, > tried an edit... the edit saved but the page didn't refresh... I bet > it's another common filter issue. Yup, I'm using renderPartial() for > AJAX updates of slots, which implies no layout (I guess), so I need to > call include_javascripts and include_stylesheets myself and now I'm > fine. > > The CMS works in 1.3. Very nice. > > Our media plugin is another story, with PHP 5.3.0 under MacPorts it is > segfaulting left and right. I suspect Doctrine 1.2.x and PHP 5.3.0 are > not getting along in some way, but segfaults in PHP are never the PHP > code's fault as such of course. > > I'll continue my notes after I commit my 1.3 branch of the cmstest > project and put the backwards-compatible include_javascripts and > include_stylesheets calls into pkContextCMSPlugin, which so far > doesn't need to be branched for 1.3 (which is great). > > -- > Tom Boutell > P'unk Avenue > 215 755 1330 > punkave.com > window.punkave.com > > -- > > You received this message because you are subscribed to the Google Groups > "symfony developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/symfony-devs?hl=en. > > > > -- > > You received this message because you are subscribed to the Google Groups > "symfony developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/symfony-devs?hl=en. > -- Tom Boutell P'unk Avenue 215 755 1330 punkave.com window.punkave.com -- You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en.
