I've noticed that project:validate generates a lot of false positives on functions and classes with names that incorporate the names of deprecated functions and classes.
That's a big problem for plugins like sfJqueryReloadedPlugin that take on the task of supporting AJAX forms (jq_remote_form_tag, etc). This generates a lot of noise and makes it hard to find real validation problems. Less critical but still bothersome, references to old classes and functions in comments are a useful way to document what something replaces but they generate false positives too. I've opened a ticket and submitted a patch that addresses these issues: http://trac.symfony-project.org/ticket/7852 The fix for names that incorporate deprecated names is very straightforward and safe so I think it is a no-brainer to include it (I use \b to match at the beginning and end of a word, very simple). The fix for comments has only one theoretical problem, which is that it would miss a class name or function name in a comment that is actually part of a quoted string and yet somehow gets transformed later into a valid reference to the class... but in practice the only likely reason to put a class name in a comment in a quoted string would be because you don't want it to be interpreted in the code you're generating, either! So I think the fix for comments is also more than safe enough for an advisory tool like the validator. I hope these can make it into the next update of Symfony 1.3 as they make using the validator a lot nicer. -- Tom Boutell P'unk Avenue 215 755 1330 punkave.com window.punkave.com -- You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en.
