I know that this way is more verbose than other stuff, and also would not keep a "clean code" or a minimalist number of lines ... but, on a large project, that uses
while ($row = $result->getNext()) or if ( $row = $result->getNext()) it will be harder to debug a if ($row == $result->getNext()) I know that some of you say that "is about style" and "is taste and not facts", but, at least me, i do try to implement the symfony coding standards as much as i can in the projects i work. And yes ... is not about "style" or "taste" is much more about discipline. And no, i do not say that sf core team isn't ... I would like you to step back 5 minutes and remember how did your coding standards evolved in the last period, or better since you have started. Russ, yes i can disable this tool as well ... but it is another tool that could help us in debugging our code. Alecs sent via htc magic On Dec 15, 2009 10:09 PM, "Lukas Kahwe Smith" <[email protected]> wrote: On 15.12.2009, at 21:03, Tom Boutell wrote: > But I much prefer your refactoring. Yes, it is a lit... its kinda of tricky to discuss coding styles because 99% is taste and not facts. imho it would make sense to adopt imho defacto standard Horde aka PEAR aka ZF (there few collisions between PEAR and ZF, I prefer PEAR in those cases, but ZF is more detailed in many OO aspects) for Symfony2. and yes i think its wise to leave assignments out of conditions. regards, Lukas Kahwe Smith [email protected] -- You received this message because you are subscribed to the Google Groups "symfony developers... -- You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en.
