As the Plugin*.class.php files are auto-generated by symfony, shouldn't the
template be fixed?
Daniel
On Dec 21, 2009, at 5:36 PM, Johannes Heinen wrote:
> So it is, but the problem becomes obvious when another, symfony-
> generated base-class inherits from the plugin-class (only in case of
> model inheritance). The class included in the plugin declares the
> method public but the (symfony-generated) Base-Class which inherits
> from the plugin-class implements it as protected (which seems correct,
> as the parent class of all Doctrine generated forms (sfFormDoctrine)
> restricts the view scope of the same method as protected).
>
> protected sfDoctrineForm::setupInheritance() > public
> pluginSfGuardGroupForm::setupInheritance() > protected
> BaseCompanyForm::setupInheritance().
>
> However, here's the patch, hopefully in correct manner:
>
> Index: PluginsfGuardGroupForm.class.php
> ===================================================================
> --- PluginsfGuardGroupForm.class.php (Revision 25733)
> +++ PluginsfGuardGroupForm.class.php (Arbeitskopie)
> @@ -13,7 +13,7 @@
> /**
> * @see sfForm
> */
> - public function setupInheritance()
> + protected function setupInheritance()
> {
> parent::setupInheritance();
>
>
>
>
>
> On Dec 21, 5:06 pm, Jonathan Wage <[email protected]> wrote:
>> So the issue is the parent declares it protected and the class included in
>> the plugin declares it as public? Can you show a patch of the change you
>> want to make and I can confirm it or not?
>>
>> Thanks, Jon
>>
>> On Mon, Dec 21, 2009 at 11:00 AM, Johannes Heinen <
>>
>>
>>
>> [email protected]> wrote:
>>> You are right, sure i will. My post should merly be understood as an
>>> inquiry for feedback before assigning possibly redundant tickets.
>>> Thanks for your reply, i'll open a ticket for this issue.
>>
>>> Greetings :)
>>
>>> On 21 Dez., 16:54, Jonathan Wage <[email protected]> wrote:
>>>> Can you report any bugs or requests on trac? It is difficult to trac
>>> things
>>>> here :(
>>
>>>> http://trac.symfony-project.com
>>
>>>> Thanks, Jon
>>
>>>> On Mon, Dec 21, 2009 at 9:46 AM, Johannes Heinen <
>>
>>>> [email protected]> wrote:
>>>>> Hi Jonathan,
>>
>>>>> please let me report a possible bug concerning the trunk as well as
>>>>> the 1.3 branch of sfDoctrineGuardPlugin - probably it is only a simple
>>>>> issue and not worth a standelone discussion. Or it is a user fail
>>>>> caused by me, in that case it is worth nothing ;)
>>
>>>>> I am using sfDoctrineGuardPlugin with the latest symfony 1.3.2DEV
>>>>> release.
>>
>>>>> This is the underlying schema file (a table that inherits from
>>>>> sfGuardGroup).
>>
>>>>> Company:
>>>>> columns:
>>>>> {.....}
>>
>>>>> inheritance:
>>>>> extends: sfGuardGroup
>>>>> type: column_aggregation
>>>>> keyField: type
>>>>> keyValue: 1
>>
>>>>> The generated Form (BaseCompanyForm) implements
>>>>> sfFormDoctrine::setupInheritance() which is declared protected, but
>>>>> also extends PluginsfGuardGroupForm (probably by a newly implemented
>>>>> schema-mechanism that regards cross-model-form-inheritance, which is a
>>>>> cool feature for sure). But in fact,
>>>>> PluginsfGuardGroupForm::setupInheritance()'s signature has the keyword
>>>>> "public". Changing it to "protected" will do, i think.
>>
>>>>> Thanks for your great work and best regards
>>>>> j
>>
>>>>> On Dec 17, 9:18 pm, Jonathan Wage <[email protected]> wrote:
>>>>>> No these features are not in SVN yet. We haven't committed anything
>>> yet.
>>
>>>>>> - Jon
>>
>>>>>> On Thu, Dec 17, 2009 at 1:04 PM, ReynierPM <[email protected]> wrote:
>>>>>>> Jonathan Wage wrote:
>>>>>>>> This is something that will come in the next version after this
>>> that
>>>>>>>> Dustin and I will work on.
>>
>>>>>>> So the SVN releases have this features since now?
>>>>>>> --
>>>>>>> Cheers
>>>>>>> ReynierPM
>>
>>>>>>> --
>>
>>>>>>> You received this message because you are subscribed to the Google
>>>>> Groups
>>>>>>> "symfony developers" group.
>>>>>>> To post to this group, send email to [email protected]
>>> .
>>>>>>> To unsubscribe from this group, send email to
>>>>>>> [email protected]<symfony-devs%[email protected]>
>>> <symfony-devs%2bunsubscr...@google groups.com>
>>>>> <symfony-devs%[email protected]<symfony-devs%[email protected]>
>>> <symfony-devs%252bunsubscr...@g ooglegroups.com>
>>
>>>>>>> .
>>>>>>> For more options, visit this group at
>>>>>>> http://groups.google.com/group/symfony-devs?hl=en.
>>
>>>>>> --
>>>>>> Jonathan H. Wage (+1 415 992 5468)
>>>>>> Open Source Software Developer & Evangelist
>>>>>> sensiolabs.com | jwage.com | doctrine-project.org |
>>> symfony-project.org
>>
>>>>>> You should follow me on Twitter:http://www.twitter.com/jwage
>>
>>>>>> You can contact Jonathan about Doctrine, Symfony and Open-Source or
>>> for
>>>>>> training, consulting, application development, or business related
>>>>> questions
>>>>>> at [email protected]
>>
>>>>> --
>>
>>>>> You received this message because you are subscribed to the Google
>>> Groups
>>>>> "symfony developers" group.
>>>>> To post to this group, send email to [email protected].
>>>>> To unsubscribe from this group, send email to
>>>>> [email protected]<symfony-devs%[email protected]>
>>> <symfony-devs%2bunsubscr...@google groups.com>
>>>>> .
>>>>> For more options, visit this group at
>>>>> http://groups.google.com/group/symfony-devs?hl=en.
>>
>>>> --
>>>> Jonathan H. Wage (+1 415 992 5468)
>>>> Open Source Software Developer & Evangelist
>>>> sensiolabs.com | jwage.com | doctrine-project.org | symfony-project.org
>>
>>>> You should follow me on Twitter:http://www.twitter.com/jwage
>>
>>>> You can contact Jonathan about Doctrine, Symfony and Open-Source or for
>>>> training, consulting, application development, or business related
>>> questions
>>>> at [email protected]
>>
>>> --
>>
>>> You received this message because you are subscribed to the Google Groups
>>> "symfony developers" group.
>>> To post to this group, send email to [email protected].
>>> To unsubscribe from this group, send email to
>>> [email protected]<symfony-devs%[email protected]>
>>> .
>>> For more options, visit this group at
>>> http://groups.google.com/group/symfony-devs?hl=en.
>>
>> --
>> Jonathan H. Wage (+1 415 992 5468)
>> Open Source Software Developer & Evangelist
>> sensiolabs.com | jwage.com | doctrine-project.org | symfony-project.org
>>
>> You should follow me on Twitter:http://www.twitter.com/jwage
>>
>> You can contact Jonathan about Doctrine, Symfony and Open-Source or for
>> training, consulting, application development, or business related questions
>> at [email protected]
>
> --
>
> You received this message because you are subscribed to the Google Groups
> "symfony developers" group.
> To post to this group, send email to [email protected].
> To unsubscribe from this group, send email to
> [email protected].
> For more options, visit this group at
> http://groups.google.com/group/symfony-devs?hl=en.
>
>
--
You received this message because you are subscribed to the Google Groups
"symfony developers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en.
