On Mar 24, 4:34 pm, Jordi Boggiano <j.boggi...@seld.be> wrote: > On 24.03.2010 17:27, Bernhard Schussek wrote: > > >> What others think? > > > I have thought of that before and think it's very well worth to be > > included in the RFC. It's not as nicely testable as the other > > approaches, but it's much cleaner than the routing magic. > > I don't know if testability is really an issue. Since in most cases you > need to test forms and all that have POST/GET input and can't just rely > on the routing parameter, we will need to find a good solution to inject > testing parameters in a request object. > > The request class has a setParameters method so you can probably abuse > that. Not for routing though, so I don't think it's a good idea to > remove routing params from the function signature, they are very handy > as they are. > > Cheers, > Jordi > > signature.asc > < 1KViewDownload
Why doesn't the Request constructor take the superglobal arrays as parameters, rather than requiring a whole load of set*() methods? Eg. $request = new Request($_GET, $_POST, $_SERVER, ...); Then can create any setup for testing. Jared -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to symfony-devs@googlegroups.com To unsubscribe from this group, send email to symfony-devs+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en To unsubscribe from this group, send email to symfony-devs+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
