On 3/29/10 9:17 AM, Davide Borsatto wrote:
There are a lot of unreviewd tickets lately.
For instance this is a (literally) 30 seconds fix:
http://trac.symfony-project.org/ticket/7499
This is a VERY good example. The patch probably fixes the problem at
hand. BUT, if you have a closer look, you will see that the fix will
BREAK every other DB driver. Using ` to escape a column name is MySQL
specific.
So, no, it's not a "30 second fix".
And the symfony ticket database is (literally) full of such bogus
patches. That's not a critic, but most of the patches cannot be
committed blindly ;) And when we have a good patch, with unit tests,
odds are it is committed the same day.
That said, if you think we have missed some tickets with good patches,
please feel free to send an email to this mailing-list for further
discussion.
Fabien
I fixed on my copy, but it seems that no one of the team saw it.
I know that (almost?) everybody is now focusing on Sf 2, but since 1.x
are still the only available releases for a safe development, they
should receive more attention...
This is not a critic, I really thank you for your work on the
framework, but the community is good and provides patches most of the
time a new bug is discovered...
On Mar 28, 10:32 pm, Andrei Dziahel<[email protected]> wrote:
Hi
2010/3/29 Jonathan Wage<[email protected]>
Hi,
On Sun, Mar 28, 2010 at 3:23 PM, Andrei Dziahel<[email protected]>wrote:
Hi.
Kris, BTW, please take a closer look at ticket
#5867<http://trac.symfony-project.org/ticket/5867>too — it's about major bug
that still exists in last 1.x release. In short,
this bug prevents values of m2m widgets in embedded forms to be saved. Due
to it, I'm (assume other symfony users as well) struggling to implement ugly
workarounds of it (say, copypasting save*List() and filling it with data
from $request).
I've made some research on fixing it and discovered the following. First
of all — I'm not enough qualified to fix it :) . Second — jwage has
implemented<http://trac.symfony-project.org/changeset/17922> a fix (or
it's still a workaround?) for sfSympalPlugin. Third — this bug is
non-trivial, and fixing it could even break BC. So, as I said, I wasn't able
to handle it and asking for gurus help.
That patch doesn't fix the problem. It fixes one problem but breaks other
stuff that I could never figure out.
Thanks for clearing it, Jon.
I didn't mentioned it before, but I've tried to apply it, had no success,
and then figured I have to perform huge job which includes rewriting forms'
tests first and then forms framework itself to incorporate it correctly.
- Jon
2010/3/28 Kris Wallsmith<[email protected]>
Thank you for this list. We are working to get the next minor release out
the door ASAP and I will personally look at each of these.
Kris
--
*Kris Wallsmith* | Release Manager
[email protected]
Portland, Oregon USA
http://twitter.com/kriswallsmith
On Mar 27, 2010, at 9:30 AM, Donald wrote:
I've been submitting tickets for symfony since about Sept 2008, and I
used to have a very good response in getting the bugs fixed. But since
Sept 2009, most of my tickets have been ignored. No one is even
reviewing them.
There are some pretty huge issues that have no been addressed, such as
ticket# 8105. Here is a complete list of all my current open tickets:
Major:
http://trac.symfony-project.org/ticket/7247
http://trac.symfony-project.org/ticket/8056
http://trac.symfony-project.org/ticket/8105
Minor:
http://trac.symfony-project.org/ticket/8077
http://trac.symfony-project.org/ticket/8078
http://trac.symfony-project.org/ticket/8091
I *really* need to get #8105 resolved. Can someone please let me know
what I need to do to get some progress on these tickets?
Thanks
P.S. Cross Posted here:
http://groups.google.com/group/symfony-users/browse_thread/thread/6ac...
--
If you want to report a vulnerability issue on symfony, please send it to
security at symfony-project.com
You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]<symfony-devs%[email protected]>
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en
To unsubscribe from this group, send email to symfony-devs+
unsubscribegooglegroups.com or reply to this email with the words
"REMOVE ME" as the subject.
--
If you want to report a vulnerability issue on symfony, please send it to
security at symfony-project.com
You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]<symfony-devs%[email protected]>
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en
To unsubscribe from this group, send email to symfony-devs+
unsubscribegooglegroups.com or reply to this email with the words
"REMOVE ME" as the subject.
--
With the best regards, Andrei.
--
If you want to report a vulnerability issue on symfony, please send it to
security at symfony-project.com
You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]<symfony-devs%[email protected]>
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en
To unsubscribe from this group, send email to symfony-devs+
unsubscribegooglegroups.com or reply to this email with the words "REMOVE
ME" as the subject.
--
Jonathan H. Wage (+1 415 992 5468)
Open Source Software Developer& Evangelist
sensiolabs.com | jwage.com | doctrine-project.org | symfony-project.org
You should follow me on Twitter:http://www.twitter.com/jwage
You can contact Jonathan about Doctrine, Symfony and Open-Source or for
training, consulting, application development, or business related questions
at [email protected]
--
If you want to report a vulnerability issue on symfony, please send it to
security at symfony-project.com
You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]<symfony-devs%[email protected]>
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en
To unsubscribe from this group, send email to symfony-devs+
unsubscribegooglegroups.com or reply to this email with the words "REMOVE
ME" as the subject.
--
With the best regards, Andrei.
--
If you want to report a vulnerability issue on symfony, please send it to
security at symfony-project.com
You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en
To unsubscribe from this group, send email to symfony-devs+unsubscribegooglegroups.com or
reply to this email with the words "REMOVE ME" as the subject.
