Ok i commit changes Patch : git://github.com/nfabre/symfony.git ticket_8838
* Can you add some unit tests? >> I added another unit tests, tell me if is enough * As noted in the ticket, can you also apply the patch to the Link class? >> It's fixed, I added unit tests * Can you fix the coding standards? >> I made some changes, but tell me if missed some rules Thanks On 7 juil, 07:59, nfabre <[email protected]> wrote: > Ok > > I make the changes > > Thanks > > On 6 juil, 19:07, Fabien Potencier <fabien.potenc...@symfony- > > project.com> wrote: > > On 7/6/10 5:50 PM, nfabre wrote: > > > > Ticket :http://trac.symfony-project.org/ticket/8838 > > > Patch : git://github.com/nfabre/symfony.git ticket_8838 > > > > The patch check if the scheme URI is egals to 'http' > > > The patch looks good but needs some more work: > > > * Can you add some unit tests? > > * As noted in the ticket, can you also apply the patch to the Link class? > > * Can you fix the coding standards? > > > Thanks, > > Fabien -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
