Martijn,
I'm not a Symfony dev so feel free to ignore my comments. I think your
unit test looks good, however it doesn't actually test the change made
(added support for memory and charset options). Your unit test is still
good and serves a purpose, but perhaps it should be moved to another
patch/branch?
Again, I'm not a Symfony dev so please ignore my two cents ;)
Brandon (aka bltcoder)
On 7/8/10 11:09 AM, Martijn wrote:
Ticket: http://trac.symfony-project.org/ticket/8824
Patch: http://github.com/martijn4evers/symfony/tree/ticket_8824
This was a great way to lean git so i hope everything went well.
I've used the patch provided by bltcoder for the DoctrineExtension and
added these options in the schema for XML DI configuration validation
( Resource/config/schema/doctrine-1.0.xsd ). There is also an
additional unit test to verify these options are allowed in the XML DI
configuration using the schema. This was my first unit test so I hope
nothing is wrong, maybe someone can double check?
--
If you want to report a vulnerability issue on symfony, please send it to
security at symfony-project.com
You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en
