error message shouldn't be hard coded into core classes either ;) On Thu, Jul 15, 2010 at 10:06 AM, Andrei Dziahel <[email protected]> wrote: > Hi. > > 2010/7/15 Sid Bachtiar <[email protected]> >> >> Hi, >> >> How do I contribute to symfony 1.2? >> >> At the moment I just have something small to add >> >> I want to change: >> >> $this->addMessage('csrf_attack', 'CSRF attack detected.'); >> >> to: >> >> $this->addMessage('csrf_attack', >> sfConfig::get('app_message_csrf_attack', 'CSRF attack detected.')); >> >> In sfValidatorCSRFToken.class.php so that I can customize the csrf attack >> message without changing the core. > > I'm absolutely sure that core classes shouldn't rely on application > settings. They actually shouldn't rely on sfConfig at all, because it makes > sfValidatorCSRFToken class coupled with sfConfig class adding unnecessary > dependency. > > -- > With the best regards, Andrei. > > -- > If you want to report a vulnerability issue on symfony, please send it to > security at symfony-project.com > > You received this message because you are subscribed to the Google > Groups "symfony developers" group. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/symfony-devs?hl=en >
-- Blue Horn Ltd - System Development http://bluehorn.co.nz -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
