Fair point. Maybe something worth doing for Symfony2 then. On 4 August 2010 11:55, ryan weaver <[email protected]> wrote:
> Hey Steve- > > I can't speak for the reason, but I think that even if this idea is 100% > sound, it wouldn't be a "bug fix" (and isn't backwards compatible) and so > couldn't be introduced into the 1.3 or 1.4 branches. > > Ryan Weaver > Lead Programmer Iostudio, LLC > http://www.sympalphp.org > http://www.thatsquality.com > Twitter: @weaverryan > > > > On Wed, Aug 4, 2010 at 3:14 AM, Stephen Melrose <[email protected]>wrote: > >> Fair enough. >> >> I don't mean to question the core devs, but what is the reasoning for >> this? Validators and PostValidators can manipulate and return form values. I >> don't see why PreValidators shouldn't be allowed to. >> >> Steve >> >> >> On 3 August 2010 17:44, Kris Wallsmith < >> [email protected]> wrote: >> >>> Pre-validators won't be changed to return values. >>> Kris >>> >>> >>> -- >>> >>> *Kris Wallsmith* | Release Manager >>> [email protected] >>> Portland, Oregon USA >>> >>> http://twitter.com/kriswallsmith >>> >>> On Aug 3, 2010, at 8:11 AM, Stephen Melrose wrote: >>> >>> Bump? Wouldn't mind knowing if I'm doing something wrong returning values >>> from a preValidator. >>> >>> >>> On 28 July 2010 18:31, Kris Wallsmith < >>> [email protected]> wrote: >>> >>>> I believe this was intentional but I'm not sure about the reasoning. >>>> Fabien? >>>> >>>> -- >>>> >>>> *Kris Wallsmith* | Release Manager >>>> [email protected] >>>> Portland, Oregon USA >>>> >>>> http://twitter.com/kriswallsmith >>>> >>>> On Jul 28, 2010, at 3:58 AM, Stephen Melrose wrote: >>>> >>>> Hey guys, >>>> >>>> I think I've found a bug with the forms, and looking at trac it >>>> appears to be quite an old one that I'd like to resolve. >>>> >>>> Please see http://trac.symfony-project.org/ticket/5952 >>>> >>>> Pre-validators at present don't return the values they are passed, so >>>> if they make any modifications to the values, they are not continued >>>> through the validation process. >>>> >>>> I can't see why the pre-validators returning the values would be an >>>> issue, unless someone can enlighten me? >>>> >>>> I've made a patch for 1.2 and 1.3/1.4, >>>> >>>> http://static.stephenmelrose.co.uk/symfony/1.2_sfValidatorSchema.patch >>>> >>>> http://static.stephenmelrose.co.uk/symfony/1.3-1.4_sfValidatorSchema.patch >>>> >>>> Steve >>>> >>>> -- >>>> If you want to report a vulnerability issue on symfony, please send it >>>> to security at symfony-project.com >>>> >>>> You received this message because you are subscribed to the Google >>>> Groups "symfony developers" group. >>>> To post to this group, send email to [email protected] >>>> To unsubscribe from this group, send email to >>>> [email protected]<symfony-devs%[email protected]> >>>> For more options, visit this group at >>>> http://groups.google.com/group/symfony-devs?hl=en >>>> >>>> >>>> >>>> -- >>>> If you want to report a vulnerability issue on symfony, please send it >>>> to security at symfony-project.com >>>> >>>> You received this message because you are subscribed to the Google >>>> Groups "symfony developers" group. >>>> To post to this group, send email to [email protected] >>>> To unsubscribe from this group, send email to >>>> [email protected]<symfony-devs%[email protected]> >>>> For more options, visit this group at >>>> http://groups.google.com/group/symfony-devs?hl=en >>>> >>> >>> >>> -- >>> If you want to report a vulnerability issue on symfony, please send it to >>> security at symfony-project.com >>> >>> You received this message because you are subscribed to the Google >>> Groups "symfony developers" group. >>> To post to this group, send email to [email protected] >>> To unsubscribe from this group, send email to >>> [email protected] >>> For more options, visit this group at >>> http://groups.google.com/group/symfony-devs?hl=en >>> >>> >>> -- >>> If you want to report a vulnerability issue on symfony, please send it to >>> security at symfony-project.com >>> >>> You received this message because you are subscribed to the Google >>> Groups "symfony developers" group. >>> To post to this group, send email to [email protected] >>> To unsubscribe from this group, send email to >>> [email protected]<symfony-devs%[email protected]> >>> For more options, visit this group at >>> http://groups.google.com/group/symfony-devs?hl=en >>> >> >> -- >> If you want to report a vulnerability issue on symfony, please send it to >> security at symfony-project.com >> >> You received this message because you are subscribed to the Google >> Groups "symfony developers" group. >> To post to this group, send email to [email protected] >> To unsubscribe from this group, send email to >> [email protected]<symfony-devs%[email protected]> >> For more options, visit this group at >> http://groups.google.com/group/symfony-devs?hl=en >> > > -- > If you want to report a vulnerability issue on symfony, please send it to > security at symfony-project.com > > You received this message because you are subscribed to the Google > Groups "symfony developers" group. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected]<symfony-devs%[email protected]> > For more options, visit this group at > http://groups.google.com/group/symfony-devs?hl=en > -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
