On 06.01.2011 15:35, Fabien Potencier wrote:
>> 1) Resources is not a namespace, so according to the rest (contents of
>> Resources/, vendor/, top level dirs) it should be called resources/.
> 
> There is a capital letter for consistency. If not, it looks really weird.

Ack. I don't really mind it.

>> 2) We said everything singular, so I guess it should in fact be
>> resource/, and Tests/ should be Test/ no ?
> 
> Related to the first point. It's plural because it's not a namespace.
> Tests/ is probably better as Test/ though.

Patch on the way for that

>> 3) The convention of using foo_bar for options and fooBar for "php"
>> stuff is nice and all, but in some contexts you have to mix, for example
>> route parameters ":foo_bar" will end up as $foo_bar in your action. What
>> should we do there? Convert automatically (maybe it's done and I didn't
>> notice)? Move everything to camel case (it'd look awkward in xml I
>> guess, and everyone would hate me)?
> 
> Conversion between upperCase and camel_case is in fact a nightmare. It
> would be probably best to only use upperCase in Symfony2 but indeed I
> will hate you if we do that ;) It's not as readable and it looks really
> ugly. That being said, it's really not that important, so if the
> majority think it would be better to have everything in upperCase, let's
> go for it. What others think?

We discussed it on irc, doesn't really make sense, the few
inconsistencies like routing params we probably can live with.

Cheers

-- 
Jordi Boggiano
@seldaek :: http://seld.be/

-- 
If you want to report a vulnerability issue on symfony, please send it to 
security at symfony-project.com

You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en

Reply via email to