Hey guys-

A few things as I'm going through the form component. At the very
least, I wanted to make sure I'm reading the intended behavior
correctly.

* The "separator" option on ChoiceField doesn't appear to be used.
Instead, a separator parameter is passed when rendering the field:

{{ form_field(field, {}, {'separator': '+++++'}) }}

If this is the intended behavior, the separator in ChoiceField should
be removed. Is that the intention?


* The third argument of the Twig form_field() function is a parameters
array (see above). Currently, the *only* use for this seems to be for
specifying the separator of the ChoiceField. Is the parameters array a
nearly-dead feature that should be killed off? If so, this would put
the separator into ChoiceField. Is that more correct?


* The "empty_value" option on ChoiceField appears to be unused. Should
we just remove this and rely on the user to specify their own
empty_value (like in symfony1)? If we *do* keep it, it appears to
still need to be implemented. It would be useful on ChoiceField
subclasses such as CountryField. Additionally, the behavior of
getEmptyValue() only returns a value if the field is *not* required.
Doesn't that mean that if a select box is required (and this feature
were fully-implemented) that it would be impossible to have a blank
entry on the top of the list? I fear I'm missing something, so please
jump in to correct me.

Thanks!

-- 
If you want to report a vulnerability issue on symfony, please send it to 
security at symfony-project.com

You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en

Reply via email to