On 20.01.2011, at 12:12, Bernhard Schussek wrote: > 2011/1/20 Lukas Kahwe Smith <[email protected]>: >> Is it really necessary to only allow setting validation groups via the >> constructor? This means that one is essentially forced to use a factory when >> one wants to support setting different validation groups for a single form. > > Yes, although the explanation why that is so is a bit lengthy. In > short: The state of a form shouldn't be changed after its construction > because this leads to potential bugs. > > Why is this a problem for you?
Like I said, if I have a form which I want to use with different validation groups I now either have to: - define one service for each group permutation - define a factory service that makes the form instances Now if we disallow setting options via setters, then I think we should make that factory service the _only_ way to make form instances. Aka make the constructor protected and provide a form creation service as part of Symfony2 core. regards, Lukas Kahwe Smith [email protected] -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
