Hi all,
Today, I've added interfaces for both the EventDispatcher and the Event
classes. It made me think again about the method signatures. And I think
we need to change them for the notifications methods.
As of now, notify(), notifyUntil(), and filter() return the Event
instance. This is a bit stupid as the event is one of the arguments of
these methods (and chaining the methods has no use case).
So, instead, I want to change the returned value as follows:
notify(): no return value
notifyUntil(): the value of getReturnValue()
filter(): the filtered value
With this change, the Event::getReturnValue() method can also be removed.
What do you think?
Fabien
--
Fabien Potencier
Sensio CEO - symfony lead developer
sensiolabs.com | symfony-project.org | fabien.potencier.org
Tél: +33 1 40 99 80 80
--
If you want to report a vulnerability issue on symfony, please send it to
security at symfony-project.com
You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en
